ebpf(python): update offsets for new pythons #3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
approved these changes
Feb 27, 2024
simonswine
approved these changes
Feb 27, 2024
Comment on lines
-3222
to
-3223
| PyRuntimeState_gilstate: 3112, | ||
| PyRuntimeState_autoTSSkey: 1848, |
There was a problem hiding this comment.
I am assuming this is because it is not a "released" version?
There was a problem hiding this comment.
I am assuming the same :)
There was a problem hiding this comment.
Actually I am surprised my integration tests did not catch it, It should fail now, because test image is based on old release candidate. I will look into it.
There was a problem hiding this comment.
PyRuntimeState_gilstate is not used on >= 3.13
And PyRuntimeState_autoTSSkey is used to read pthread_key which is an int and a counter and almost always it is zero. I am not 100% sure, but I think the test did not fail because the offset is wrong but it still read some garbage uint32=0.
fix fix add more pythons, add some offsets validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.