Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flag to disable printing banner #3123

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Conversation

bryanhuhta
Copy link
Contributor

In production environments, users may not want the banner to be printed because doesn't conform to any logging format, which can muddle logs. This PR adds a flag which allows users to disable printing the banner.

@bryanhuhta bryanhuhta self-assigned this Mar 20, 2024
@bryanhuhta bryanhuhta requested review from a team as code owners March 20, 2024 16:36
Copy link
Contributor

@aleks-p aleks-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryanhuhta bryanhuhta enabled auto-merge (squash) March 20, 2024 17:02
@bryanhuhta bryanhuhta merged commit 95cc78f into main Mar 20, 2024
16 checks passed
@bryanhuhta bryanhuhta deleted the disable-login-banner branch March 20, 2024 17:09
@fede843
Copy link

fede843 commented Mar 20, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants