Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move mock struct to test file #3177

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

rlaisqls
Copy link
Contributor

@rlaisqls rlaisqls commented Apr 6, 2024

It is more appropriate for SymTab and Sym structures to be separated into test files since they are only used in tests, not in general code. Additionally, adding the Mock prefix will clearly indicate to other developers that these structures are intended for testing purposes only, reducing the potential for confusion.

Therefore, I propose moving these two structures to test files and renaming them.

@CLAassistant
Copy link

CLAassistant commented Apr 6, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@korniltsev korniltsev merged commit 94564fa into grafana:main Apr 6, 2024
17 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants