fix: discard invalid samples at read #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
force-pushed
the
fix/invalid-samples
branch
from
4f952ac
to
ff829e5
Compare
simonswine
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
LGTM
I have also found this path, where it probably would make sense to add a check too.:
pyroscope/pkg/phlaredb/schemas/v1/profiles.go
Line 339 in 032c28b
simonswine
force-pushed
the
fix/invalid-samples
branch
from
4a5fa80
to
ff829e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been discovered that some of the persisted profiles may contain invalid samples (stack trace ID == 0). As an immediate fix, such samples should be discarded, as further processing does not expect "empty" stack traces. This has led to numerous cryptic failures (#3164 and #2377, for example).
We should also ensure that such profiles are discarded before they gets writtien to the block (see #3194)