Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tenant-settings from Ingress #3221

Merged

Conversation

nasa9084
Copy link
Contributor

@nasa9084 nasa9084 commented Apr 15, 2024

The backend Service is no longer available as it was removed in #2922.
Honestly, I don't know what it was in detail but the PR said the service is not relevant when running outside of Grafana Cloud so I believe this ingress path setting can be removed as well.

@nasa9084 nasa9084 requested a review from a team as a code owner April 15, 2024 06:02
@CLAassistant
Copy link

CLAassistant commented Apr 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing this – you're right, the route is not needed here

@kolesnikovae kolesnikovae merged commit 990624b into grafana:main Apr 23, 2024
16 checks passed
@nasa9084 nasa9084 deleted the remove-tenant-settings-from-ingress branch April 24, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants