Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement fuzzer for Merge_Single #3222

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Implement fuzzer for Merge_Single #3222

merged 6 commits into from
Apr 24, 2024

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Apr 15, 2024 •
edited

Not too sure if there is a better/more performant way of doing that. But this also uncovered a few cases already 馃檪

@simonswine simonswine mentioned this pull request Apr 15, 2024
Merged
@simonswine
Implement fuzzer for Merge_Single
c98d71b
@simonswine
Use protobuf decoding after fuzzing
e634864 
This iterates a lot quicker through valid examples. I have also added
multiple files onto the corpus.
@simonswine simonswine force-pushed the 20240415_implement-fuzzing-merge branch from b62e396 to e634864 Compare April 16, 2024 14:30
@simonswine simonswine marked this pull request as ready for review April 16, 2024 14:54
@simonswine simonswine requested a review from a team as a code owner April 16, 2024 14:54
@simonswine simonswine marked this pull request as draft April 16, 2024 16:31
@kolesnikovae
Copy link
Collaborator

I've been running it on main for 2 hours with no failures 馃帀

simonswine
simonswine commented Apr 17, 2024
View reviewed changes
pkg/pprof/merge_test.go Outdated Show resolved Hide resolved
@simonswine
Copy link
Contributor Author

simonswine commented Apr 17, 2024 •
edited

@aleks-p I have looked into how we can actually run those Fuzz tests regularly. Not too sure if it will work, but at least I tried to have a valid config around 馃檪

@kolesnikovae I was curious how often we get post decoding and merge:

postDecode: 5325/522287 (last 3s, total) postMerge 5325/520733 (last 3s, total)

# Also for completeness when encoding/decoding was gob based:
postDecode: 5/39149 (last 3s, total) postMerge 5/39149 (last 3s, total)

@simonswine simonswine marked this pull request as ready for review April 17, 2024 12:25
@simonswine simonswine merged commit 692323c into grafana:main Apr 24, 2024
16 checks passed
@simonswine simonswine mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolesnikovae kolesnikovae kolesnikovae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonswine @kolesnikovae