[DOC Update flamegraphs.md #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knylander-grafana
added
type/docs
|
This PR must be merged before a backport PR will be created. |
1 similar comment
|
This PR must be merged before a backport PR will be created. |
aleks-p
approved these changes
Apr 19, 2024
Co-authored-by: Aleksandar Petrov <8142643+aleks-p@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Update flamegraphs.md * Apply suggestions from code review Co-authored-by: Aleksandar Petrov <8142643+aleks-p@users.noreply.github.com> --------- Co-authored-by: Aleksandar Petrov <8142643+aleks-p@users.noreply.github.com> (cherry picked from commit 589b4c5)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3233-to-release/v1.5 origin/release/v1.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 589b4c5f71ad8ee5830e807a1652027e59a81b52When the conflicts are resolved, stage and commit the changes: If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-3233-to-release/v1.5
# Create the PR body template
PR_BODY=$(gh pr view 3233 --json body --template 'Backport 589b4c5f71ad8ee5830e807a1652027e59a81b52 from #3233{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[release/v1.5] [DOC Update flamegraphs.md" --body-file - --label "type/docs" --label "backport" --base release/v1.5 --milestone release/v1.5 --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-3233-to-release/v1.5
# Create a pull request where the `base` branch is `release/v1.5` and the `compare`/`head` branch is `backport-3233-to-release/v1.5`.
# Remove the local backport branch
git switch main
git branch -D backport-3233-to-release/v1.5 |
knylander-grafana
added a commit
that referenced
this pull request
Apr 19, 2024
* Update flamegraphs.md * Apply suggestions from code review Co-authored-by: Aleksandar Petrov <8142643+aleks-p@users.noreply.github.com> --------- Co-authored-by: Aleksandar Petrov <8142643+aleks-p@users.noreply.github.com> (cherry picked from commit 589b4c5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add link to the Pyroscope UI doc in the flame graph doc.