-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Update screenshots in Pyroscope UI' #3234
Merged
knylander-grafana
merged 4 commits into
grafana:main
from
knylander-grafana:3129-update-screenshots-UI
Apr 22, 2024
Merged
[DOC] Update screenshots in Pyroscope UI' #3234
knylander-grafana
merged 4 commits into
grafana:main
from
knylander-grafana:3129-update-screenshots-UI
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knylander-grafana
added
the
type/docs
Improvements for doc docs. Used by Docs team for project management
label
Apr 19, 2024
knylander-grafana
added
the
backport release/v1.5
This label will backport a merged PR to the release/v1.5 branch
label
Apr 19, 2024
This PR must be merged before a backport PR will be created. |
bryanhuhta
approved these changes
Apr 22, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Update screenshots in Pyroscope UI' * Apply suggestions from code review (cherry picked from commit 9791276)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3234-to-release/v1.5 origin/release/v1.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 97912763a3b6eeb610833b2e53adf7b7efac745a When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-3234-to-release/v1.5
# Create the PR body template
PR_BODY=$(gh pr view 3234 --json body --template 'Backport 97912763a3b6eeb610833b2e53adf7b7efac745a from #3234{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[release/v1.5] [DOC] Update screenshots in Pyroscope UI'" --body-file - --label "type/docs" --label "backport" --base release/v1.5 --milestone release/v1.5 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-3234-to-release/v1.5
# Create a pull request where the `base` branch is `release/v1.5` and the `compare`/`head` branch is `backport-3234-to-release/v1.5`.
# Remove the local backport branch
git switch main
git branch -D backport-3234-to-release/v1.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport release/v1.5
This label will backport a merged PR to the release/v1.5 branch
backport-failed
type/docs
Improvements for doc docs. Used by Docs team for project management
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the screenshots in the Pyroscope UI doc to reflect Pyroscope's UI.
Fixes: #3129
Page preview