Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update the demo links on the SDK pages #3240

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

kolesnikovae
Copy link
Collaborator

@kolesnikovae kolesnikovae commented Apr 23, 2024

  • Update the Java, Go, Python, Ruby demo link to point to [play.grafana.org].
  • Correct the link to the Java examples folder. The reference to the "Java blog post" actually pertains to the README for the "Java examples" page, so I'm removing it.

@kolesnikovae kolesnikovae changed the title [DOC] Update the links on the Java SDK page [DOC] Update the demo links on the SDK pages Apr 23, 2024
@kolesnikovae kolesnikovae marked this pull request as ready for review April 23, 2024 03:14
@kolesnikovae kolesnikovae requested review from a team as code owners April 23, 2024 03:14
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the docs!

@simonswine simonswine added type/docs Improvements for doc docs. Used by Docs team for project management backport release/v1.5 This label will backport a merged PR to the release/v1.5 branch labels Apr 24, 2024
Copy link
Contributor

This PR must be merged before a backport PR will be created.

1 similar comment
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@knylander-grafana knylander-grafana merged commit d111cdf into main Apr 24, 2024
16 checks passed
@knylander-grafana knylander-grafana deleted the docs/update-java-links branch April 24, 2024 16:43
github-actions bot pushed a commit that referenced this pull request Apr 24, 2024
* docs: update links in the Java SDK page

* docs: update links in the Go, Python, and Ruby pages

* Update docs/sources/configure-client/language-sdks/go_push.md

---------

Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
(cherry picked from commit d111cdf)
Copy link
Contributor

The backport to release/v1.5 failed:

Validation Failed: "Could not resolve to a node with the global id of 'T_kwDOAG3Mbc4AczmP'."

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3240-to-release/v1.5 origin/release/v1.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x d111cdf24bfad7753e1467d79e20ce1b05ade96d

When the conflicts are resolved, stage and commit the changes:

git add . && git cherry-pick --continue

If you have the GitHub CLI installed:

# Push the branch to GitHub:
git push --set-upstream origin backport-3240-to-release/v1.5
# Create the PR body template
PR_BODY=$(gh pr view 3240 --json body --template 'Backport d111cdf24bfad7753e1467d79e20ce1b05ade96d from #3240{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[release/v1.5] [DOC] Update the demo links on the SDK pages" --body-file - --label "type/docs" --label "backport" --base release/v1.5 --milestone release/v1.5 --web

Or, if you don't have the GitHub CLI installed (we recommend you install it!):

# Push the branch to GitHub:
git push --set-upstream origin backport-3240-to-release/v1.5

# Create a pull request where the `base` branch is `release/v1.5` and the `compare`/`head` branch is `backport-3240-to-release/v1.5`.

# Remove the local backport branch
git switch main
git branch -D backport-3240-to-release/v1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/v1.5 This label will backport a merged PR to the release/v1.5 branch backport-failed type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants