Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: panic recovery interceptor #3246

Merged
merged 2 commits into from
Apr 25, 2024
Merged

fix: panic recovery interceptor #3246

merged 2 commits into from
Apr 25, 2024

Conversation

kolesnikovae
Copy link
Collaborator

@kolesnikovae kolesnikovae commented Apr 24, 2024 •
edited
Loading

We have a metric that counts recovered panics – pyroscope_panic_total, however it does not include panics recovered in gRPC handlers

@kolesnikovae kolesnikovae marked this pull request as ready for review April 24, 2024 09:49
@kolesnikovae kolesnikovae requested a review from a team as a code owner April 24, 2024 09:49
simonswine
simonswine approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for looking into that

@kolesnikovae kolesnikovae merged commit 232b07a into main Apr 25, 2024
16 checks passed
@kolesnikovae kolesnikovae deleted the fix/panic-recovery-interceptor branch April 25, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonswine simonswine simonswine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kolesnikovae @simonswine