Example and docs for Python span profiles #3252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aleks-p
commented
Apr 25, 2024
aleks-p
commented
- enables OpenTelemetry based tracing in the Python ride share Flask example
- adds the Python ride share Flask app to examples/tracing/tempo, to demonstrate span profiles in Python
- adds docs for Python span profiles
| @@ -36,7 +36,7 @@ To use Span Profiles, you need to: | |||
| Your applications must be instrumented for profiling and tracing before you can use span profiles. | |||
|
|
|||
| * Profiling: Your application must be instrumented with Pyroscope's .NET instrumentation library. Refer to the [.NET]({{< relref "../language-sdks/dotnet" >}}) guide for instructions. | |||
| * Tracing: Your application must be instrumented with OpenTelemetry traces. Refer to the [OpenTelemetry](https://opentelemetry.io/docs/net/getting-started/) guide for isntructions. | |||
| * Tracing: Your application must be instrumented with OpenTelemetry traces. Refer to the [OpenTelemetry](https://opentelemetry.io/docs/languages/net/getting-started/) guide for isntructions. | |||
There was a problem hiding this comment.
Thank you for updating the links!
knylander-grafana
added
the
type/docs
|
Do you want to backport this PR to 1.5 so it will be published before the next release? |
aleks-p
added
the
backport release/v1.5
|
This PR must be merged before a backport PR will be created. |
kolesnikovae
approved these changes
Apr 26, 2024
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Anton Kolesnikov <anton.e.kolesnikov@gmail.com>
aleks-p
force-pushed
the
example/python-span-profiles
branch
from
7779324
to
9034445
Compare
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3252-to-release/v1.5 origin/release/v1.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 960fc3221b738f4cf374ffa29ae3528588435313When the conflicts are resolved, stage and commit the changes: If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-3252-to-release/v1.5
# Create the PR body template
PR_BODY=$(gh pr view 3252 --json body --template 'Backport 960fc3221b738f4cf374ffa29ae3528588435313 from #3252{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[release/v1.5] Example and docs for Python span profiles" --body-file - --label "type/docs" --label "backport" --base release/v1.5 --milestone release/v1.5 --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-3252-to-release/v1.5
# Create a pull request where the `base` branch is `release/v1.5` and the `compare`/`head` branch is `backport-3252-to-release/v1.5`.
# Remove the local backport branch
git switch main
git branch -D backport-3252-to-release/v1.5 |
aleks-p
added a commit
that referenced
this pull request
Apr 26, 2024
* Add example for Python span profiles * Add docs for Python span profiles * Apply suggestions from code review Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> * Update docs/sources/configure-client/trace-span-profiles/_index.md Co-authored-by: Anton Kolesnikov <anton.e.kolesnikov@gmail.com> --------- Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> Co-authored-by: Anton Kolesnikov <anton.e.kolesnikov@gmail.com> (cherry picked from commit 960fc32)
aleks-p
added a commit
that referenced
this pull request
Apr 29, 2024
* Add example for Python span profiles * Add docs for Python span profiles * Apply suggestions from code review Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> * Update docs/sources/configure-client/trace-span-profiles/_index.md Co-authored-by: Anton Kolesnikov <anton.e.kolesnikov@gmail.com> --------- Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> Co-authored-by: Anton Kolesnikov <anton.e.kolesnikov@gmail.com> (cherry picked from commit 960fc32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.