Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ebpf testdata #3254

Closed

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine marked this pull request as ready for review April 25, 2024 17:24
@aleks-p
Copy link
Contributor

aleks-p commented Apr 25, 2024

Last time I looked at this, these files were not duplicate - their sizes are different. If you google some of these kernel files you'll find that typically both sets are together and they likely have a different purpose.

Also, if someone runs these instructions, the files will be brought in again:
https://github.com/pyroscope-io/pyroscope-ebpf-testdata/blob/main/qemu_img/readme.txt

I am ok with removing them (I find dealing with the dirty Git repo annoying as well) but perhaps @korniltsev can share his thoughts?

@korniltsev
Copy link
Collaborator

Thanks Aleks I think you are right
https://github.com/torvalds/linux/blob/master/net/netfilter/xt_DSCP.c
https://github.com/torvalds/linux/blob/master/net/netfilter/xt_dscp.c
I think we need to revert submodule changes

I guess I do not have such issues because I have CaseSensitive APFS on my mac

@simonswine
Copy link
Contributor Author

simonswine commented Apr 26, 2024

Thanks Aleks I think you are right https://github.com/torvalds/linux/blob/master/net/netfilter/xt_DSCP.c https://github.com/torvalds/linux/blob/master/net/netfilter/xt_dscp.c I think we need to revert submodule changes

I guess I do not have such issues because I have CaseSensitive APFS on my mac

From my googling I need to format to get this. When I have to format I probably just switch to Asahi 😂

@simonswine simonswine closed this Apr 26, 2024
@aleks-p
Copy link
Contributor

aleks-p commented Apr 26, 2024

It would still be nice to "fix" this in some way, perhaps by ignoring these files and pulling them in with a script when needed. I don't know how easy that is though.

@korniltsev
Copy link
Collaborator

  1. you can create a case sensitive volume and put repo there.
  2. we can move the files needed for VM building into yet another repo (Remove lowercase duplicate modules pyroscope-io/pyroscope-ebpf-testdata#4)
  3. maybe you can try to apply 'git update-index --assume-unchanged` on those files and git would be happy to ignore them, but i am not sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants