Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Clarify required config options for Java span profiles #3255

Conversation

knylander-grafana
Copy link
Contributor

Added the two required configuration options for Java SDK to product span profiles.

@knylander-grafana knylander-grafana added type/docs Improvements for doc docs. Used by Docs team for project management backport release/v1.5 This label will backport a merged PR to the release/v1.5 branch labels Apr 26, 2024
@knylander-grafana knylander-grafana self-assigned this Apr 26, 2024
@knylander-grafana knylander-grafana requested review from a team as code owners April 26, 2024 05:08
@knylander-grafana knylander-grafana changed the title Clarify required config options for Java span profiles [DOC] Clarify required config options for Java span profiles Apr 26, 2024
Copy link
Contributor

This PR must be merged before a backport PR will be created.

1 similar comment
Copy link
Contributor

This PR must be merged before a backport PR will be created.

Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that is correct:

The two variables allow to enable lock and heap profiling, which by default is of.

There is no support for span profiles for lock and heap profiles at all.

@simonswine simonswine closed this Apr 26, 2024
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@knylander-grafana
Copy link
Contributor Author

Thank you for closing this PR.

I opened a new doc issue to capture some updates to clarify which instrumentation methods support which profiler types. #3259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/v1.5 This label will backport a merged PR to the release/v1.5 branch type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants