Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ebpf): handle case when self is put in cell #3284

Merged
merged 9 commits into from
May 9, 2024
Merged

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented May 8, 2024

  • fix case when self is captured by some inner scope (functions or lambdas) - see reproducer
  • add try_... macros to maybe cleanup code
  • move code related to class names to a separate function get_class_name with early returns to minimize nesting
  • speedup test by pulling images concurrently and decreasing loadgen
  • change playground config to embed SessionOptions to avoid code duplication

Reproducer:

https://github.com/pyroscope-io/pyroscope-ebpf-testdata/blob/e567550674d0312c3a2f2d07ea3bb395a13a085b/rideshare-flask-no-pip/lib/server.py#L45-L59

@korniltsev korniltsev requested a review from simonswine May 8, 2024 10:31
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korniltsev korniltsev merged commit 658bef5 into main May 9, 2024
27 checks passed
@korniltsev korniltsev deleted the ebpf-self-cell-fix branch May 9, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants