Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #439

Merged
merged 14 commits into from Oct 7, 2021
Merged

Cleanup #439

merged 14 commits into from Oct 7, 2021

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Oct 5, 2021

  • Add typescript support (the use of types can reduce a whole class of bugs)
  • Migrate tooltip/highlight components to typescript (as a first example on how typescript code will look like)
  • Add typescript linting (which also runs against js files so it increased our warnings to 416, although some are debatable )
  • Add sourcemaps to local and prod build (since the codebase is public there's no point not publishing it)
  • Add CSS Modules (to have more scoped CSS, which helps with maintenance)
  • Add CSS Modules linting (requires all classes within a css module to be used)

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #439 (08051a2) into main (ecce5d6) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
- Coverage   51.66%   51.64%   -0.01%     
==========================================
  Files         125      125              
  Lines        5696     5719      +23     
==========================================
+ Hits         2942     2953      +11     
- Misses       2470     2479       +9     
- Partials      284      287       +3     
Impacted Files Coverage Δ
pkg/server/render.go 67.47% <ø> (ø)
pkg/agent/upstream/remote/remote.go 63.24% <0.00%> (-2.94%) ⬇️
pkg/agent/profiler/profiler.go 0.00% <0.00%> (ø)
pkg/agent/session.go 63.91% <0.00%> (+5.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecce5d6...08051a2. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

pyroscopebot commented Oct 5, 2021

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 156.10 156.22 0.13 (0.08%) 5%
total items processed 132790.00 133117.00 327.00 (0.25%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against 806e149

@eh-am eh-am marked this pull request as ready for review October 5, 2021 23:18
@eh-am eh-am merged commit 29781f8 into main Oct 7, 2021
@eh-am eh-am deleted the cleanup branch October 7, 2021 13:00
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants