Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace zap with slog to log traceID #22

Merged
merged 3 commits into from
Aug 29, 2023
Merged

refactor: replace zap with slog to log traceID #22

merged 3 commits into from
Aug 29, 2023

Conversation

theSuess
Copy link
Member

No description provided.

@dgzlopes dgzlopes requested a review from roobre August 24, 2023 10:32
roobre
roobre reviewed Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@roobre roobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Other than the two small nits I've mentioned, when running some tests I noticed that go.mod et. al do not seem to be clean. Could you run go mod tidy && go mod vendor and update the PR?

Thank you!

cmd/main.go Show resolved Hide resolved
cmd/main.go Show resolved Hide resolved
@theSuess
Copy link
Member Author

Should all be resolved now!

@roobre roobre merged commit 6aa0025 into grafana:main Aug 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roobre roobre roobre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theSuess @roobre