Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continue PR: " docs: improve documentation around gathering telemetry" #34

Merged
merged 13 commits into from
Oct 6, 2023

Conversation

ppcano
Copy link
Collaborator

@ppcano ppcano commented Oct 4, 2023

This PR continues #33. I wait for a decision whether it should be merged into the same branch/PR.

(1) - For easier docker setup, this PR adds docker-compose files: docker-compose-local.yaml and docker-compose-cloud.yaml

(2) - Updated readme instructions

(3) - Could not setup Loki (see error on this diff). We can try i the Loki integration in a following PR.

(4) - Next, on another PR, I want to include a case to send k6 metrics to Prometheus and visualize with the pre-built dashboards.

I have tested both docker compose setups and they work well. PR seems ready - adding also @dgzlopes for review.

@ppcano ppcano requested a review from theSuess October 4, 2023 06:47
@theSuess
Copy link
Member

theSuess commented Oct 5, 2023

The issue regarding the autoconfigure module is probably caused by token permissions. The token needs the stacks:read scope. It sounds like this is missing. We'll have to decide if we want to put the extra burden on token creation or have the user collect all the relevant infos ({prom,loki,tempo,pyroscope} url, tenant) themselves

cmd/main.go Outdated Show resolved Hide resolved
@ppcano
Copy link
Collaborator Author

ppcano commented Oct 5, 2023

The issue regarding the autoconfigure module is probably caused by token permissions. The token needs the stacks:read scope. It sounds like this is missing.

@theSuess - Yep, that was, thank you! I added a minor comment.

I got confused because I could not find the GET stack API documentation. Should I open an issue?

@ppcano ppcano merged commit 15c5d01 into main Oct 6, 2023
1 check passed
@dgzlopes dgzlopes deleted the pepe/docs/grafana-agent branch October 6, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants