Unify service names #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roobre
force-pushed
the
unified-service-names
branch
from
6ec1e30
to
cd74751
Compare
roobre
force-pushed
the
unified-service-names
branch
from
cd74751
to
2d8b3bf
Compare
dgzlopes
approved these changes
Nov 6, 2023
roobre
force-pushed
the
unified-service-names
branch
4 times, most recently
from
fbf8c15
to
7cd4a37
Compare
theSuess
approved these changes
Nov 6, 2023
This is now hardcoded inside the microservices handlers
roobre
force-pushed
the
unified-service-names
branch
from
7cd4a37
to
33f3347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the main function created a single
TracerProviderthat was passed down to the httpServer. As trace resources, such asservice.name, are immutable, this approach had the limitation of all tracing middlewares using the sameservice.name. When deploying in Docker, as there was only one service, all "microservices" reported the same service name.This PR introduces a new object called
TraceInstaller, which creates fresh newTracerProviderinstances for each handler that is instrumented. This allows different handlers to specify their own service name, even when they run inside the same process. By doing this, we get the same trace format in docker, where different endpoints live within the same process, as we do in Kubernetes, where each service gets their own pod.As a comparison, this is how a trace looked before and after the change, both deployed in docker as a single container:
Tasklist: