Add support to inject errors using headers #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lantero
requested changes
May 13, 2024
@Lantero I added a section in the documentation in f872576500. |
dgzlopes
reviewed
May 14, 2024
README.md
Outdated
| Example of header usage: | ||
|
|
||
| ``` | ||
| curl -v -X POST localhost:3333/api/pizza -H "X-Error: catalog-timeout-inserting" -H "X-User-Id: 123" -d '{}' |
There was a problem hiding this comment.
cc @Lantero
It would be nice if you could define the probability of this error happening.
Wdyt?
E.g., X-Error: catalog-timeout-inserting-80 or something like that
There was a problem hiding this comment.
Or, maybe the Envoy approach would be better if we went in this direction.
It would also let users add multiple failures.
There was a problem hiding this comment.
I updated the PR to support multiple failures in 06472b58c6.
vortegatorres
changed the title
…rror header by multiple header one for each type of error
Lantero
approved these changes
Jun 6, 2024
dgzlopes
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.