Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename workflow step, target workflow release #136

Merged
merged 4 commits into from
Mar 29, 2022
Merged

Rename workflow step, target workflow release #136

merged 4 commits into from
Mar 29, 2022

Conversation

fridgepoet
Copy link
Member

@fridgepoet fridgepoet commented Mar 29, 2022 •
edited

This step was the same name as the common workflow step, so it was redundant

Screen Shot 2022-03-29 at 12 11 03

@fridgepoet fridgepoet requested a review from a team as a code owner March 29, 2022 09:59
@fridgepoet fridgepoet requested review from kevinwcyu and vickyyyyyyy and removed request for a team March 29, 2022 09:59
@github-actions
Copy link

Code coverage report for PR #136

Go TypeScript
main 46.2% 88.19%
PR 46.2% 88.19%
difference 0% 0%

andresmgot
andresmgot approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the change in the title?

@fridgepoet
Copy link
Member Author

why the change in the title?

Right, lacking some explanation there!
I noticed while I was calling the workflow from timestream that the step name here is identical to the step name in the common workflow. That creates just a duplication in the title. I am using "workflow-call" based on an example from github now.

@fridgepoet fridgepoet merged commit 821c2dc into main Mar 29, 2022
@fridgepoet fridgepoet deleted the workflow branch March 29, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresmgot andresmgot andresmgot approved these changes

@kevinwcyu kevinwcyu Awaiting requested review from kevinwcyu kevinwcyu is a code owner automatically assigned from grafana/aws-datasources

@vickyyyyyyy vickyyyyyyy Awaiting requested review from vickyyyyyyy vickyyyyyyy is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fridgepoet @andresmgot