Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade all dependencies to latest compatible versions #139

Merged
merged 6 commits into from
Apr 1, 2022

Conversation

kishaningithub
Copy link
Contributor

@kishaningithub kishaningithub commented Mar 31, 2022

@kishaningithub kishaningithub requested a review from a team as a code owner March 31, 2022 12:16
@kishaningithub kishaningithub requested review from kevinwcyu and vickyyyyyyy and removed request for a team March 31, 2022 12:16
@kishaningithub
Copy link
Contributor Author

This is the issue which is failing the pipeline. Need help to resolve the same. Thanks in advance :-)

Screenshot
Screenshot 2022-03-31 at 6 13 40 PM

@andresmgot
Copy link
Contributor

@fridgepoet any clues of that failure? ^

In any case, this is fine, nothing else that you need to do here. Let's see if we can easily fix the issue, if not we can merge the PR as it is.

@kishaningithub
Copy link
Contributor Author

@andresmgot I think the problem is because create-or-update-comment github action does not have permission to update issue status in another repository which is linked by this PR.

@kishaningithub
Copy link
Contributor Author

For some reason the association with the other repo's issue is not getting removed even after removing the pr description

screenshot
Screenshot 2022-03-31 at 10 07 27 PM

@kishaningithub
Copy link
Contributor Author

Since the above did not fix it, have changed the PR description to what was there originally

@fridgepoet Would need your help for sure to fix it

Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the details! We can merge this in the meantime

@andresmgot andresmgot merged commit 390d24b into grafana:main Apr 1, 2022
@kishaningithub kishaningithub deleted the bump-aws-grafana-sdk branch April 1, 2022 07:46
@kishaningithub
Copy link
Contributor Author

@andresmgot Thanks for the merge! :-) Can you kindly tag a new release for this? :-)

@andresmgot
Copy link
Contributor

andresmgot commented Apr 1, 2022

Just released here @kishaningithub: https://github.com/grafana/redshift-datasource/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants