Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: Render SQL editor in case feature toggle is enabled #151

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

sunker
Copy link
Collaborator

@sunker sunker commented Jun 13, 2022

Renders the SQL editor from grafana/experimental in case the redshiftExperimentalUI feature toggle is enabled. It's a bit weird with just one index.tsx file in the src/SQLEditor folder, but more things will go in here in the next PR.

Part of #108
Fixes #150

@sunker sunker added type/feature-request New feature or request effort/small up to 1 day labels Jun 13, 2022
@sunker sunker requested a review from a team as a code owner June 13, 2022 14:43
@sunker sunker requested review from andresmgot and sarahzinger and removed request for a team June 13, 2022 14:43
@github-actions
Copy link

github-actions bot commented Jun 13, 2022

Code coverage report for PR #151

Go TypeScript
main 45.9% 88.19%
PR 45.9% 88%
difference 0% -.19%

src/SQLEditor/index.tsx Outdated Show resolved Hide resolved
src/RedshiftSQLEditor/index.tsx Outdated Show resolved Hide resolved
@sunker sunker merged commit 340bfc9 into main Jun 14, 2022
@sunker sunker deleted the render-experimental-code-editor branch June 14, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small up to 1 day type/feature-request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete: Render SQL editor in case feature toggle is enabled
2 participants