Align Monaco language with official language ref #156
Conversation
sunker
requested review from
sarahzinger and
yaelleC
and removed request for
a team
|
Code coverage report for PR #156
|
| @@ -176,478 +182,301 @@ export const keywords = [ | |||
| ]; | |||
|
|
|||
| export const builtinFunctions = [ | |||
| 'current_schema', | |||
There was a problem hiding this comment.
Do we need to migrate old queries that are using these lowercase functions?
(I have never touched this language file so not sure how it's used 😉 )
There was a problem hiding this comment.
At the moment, the language is only used for providing syntax highlighting. Functions are purple in the code editor for example. Non tokenized functions and keywords can still be used - just not with syntax highlighting.
There was a problem hiding this comment.
So with this change, a query that used to be highlighted might no longer be (for the functions especially), but there will be no change in terms of running/results of the query correct?
Sounds like a fair tradeoff for a better alignment 👍
Updating keywords and functions according to official language ref. Probably not 100% aligned, but should be much better than before.
Fixes #155
Part of #108