-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grafana dev dependencies to v8.5.10 #194
Conversation
Backend code coverage report for PR #194 |
Frontend code coverage report for PR #194
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code seems good! I didn't do any manual testing but so long as it builds ok for you let's ship! 🚀
@@ -84,6 +84,7 @@ export function ConfigEditor(props: Props) { | |||
}); | |||
}); | |||
} | |||
// eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed? seems like nothing is changing? maybe just fixing an old lint error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably updated packages pulls in new eslint rules?
@@ -227,7 +229,6 @@ export function ConfigEditor(props: Props) { | |||
}, | |||
}) | |||
} | |||
css={undefined} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆
@@ -8,6 +8,7 @@ export const mockDatasource = new DataSource({ | |||
type: 'redshift-datasource', | |||
name: 'Redshift Data Source', | |||
jsonData: {}, | |||
access: 'direct', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really sure, think the type just expects an access property.
Separating out the dev dependency updates from #177 into a separate PR.