-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to create-plugin #195
Conversation
Backend code coverage report for PR #195 |
Frontend code coverage report for PR #195 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff! Didn't manually test it tho so let me know if you want help QA-ing or anything
build: | ||
context: ./.config | ||
args: | ||
grafana_version: ${GRAFANA_VERSION:-9.1.2} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not the best at docker, do you know will this run grafana 9.1.2 or will it run "latest" from the dockerfile? I suppose it doesn't make a huge difference I'm just curious how this all plugs together, and if maybe we should pin this set up to a particular version when we run yarn server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming its the second one, because I imagine that they would just use 9.1.2 otherwise, but I'm not sure.
Migrates from grafana-toolkit to create-plugin.
Fixes #185