Remove run and cancel buttons in annotations editor #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idastambuk
commented
Jan 31, 2023
| import { AnnotationsQueryCodeEditor } from './AnnotationsQueryCodeEditor'; | ||
|
|
||
| export const RedshiftAnnotationsSupport = { | ||
| QueryEditor: AnnotationsQueryCodeEditor, |
There was a problem hiding this comment.
Added all this into separate files so it's neater for when getDefaultQuery will be added later(in Grafana 9.5)
|
Backend code coverage report for PR #206 |
|
Frontend code coverage report for PR #206
|
This was referenced Jan 31, 2023
fridgepoet
approved these changes
Jan 31, 2023
kevinwcyu
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In annotations editor we have 3 ways to run a query - with the buttons "Run" and "Cancel", the TEST button, as well as onBlur. This removes the extra buttons, the same as in the Redshift variable editor.
Before:
After:
