Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type in provisioning docs #246

Merged
merged 1 commit into from Oct 6, 2023
Merged

Conversation

StephenKing
Copy link
Contributor

The README suggests to use as data source type 'redshift', which, however, does not work.

type: redshift

The correct type is grafana-redshift-datasource.

"id": "grafana-redshift-datasource",

Fixes: #244

The README suggestes to use as data source type 'redshift',
which, however, does not work. The correct type is
'grafana-redshift-datasource'.

Fixes: grafana#244
@StephenKing StephenKing requested a review from a team as a code owner August 29, 2023 09:49
@CLAassistant
Copy link

CLAassistant commented Aug 29, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@fridgepoet fridgepoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that! Not sure if you saw, but would you sign our CLA, please?

@sarahzinger
Copy link
Member

@StephenKing mind signing out CLA? We can't accept your submission with out it, thanks!

@StephenKing
Copy link
Contributor Author

@sarahzinger not so much a fan of signing CLAs, but given the value that we get from Grafana, fine for me ❤️

@fridgepoet fridgepoet merged commit fcd334a into grafana:main Oct 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provisioning documentation shows wrong type
4 participants