Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Node 18 #249

Merged
merged 1 commit into from Oct 27, 2023
Merged

Support Node 18 #249

merged 1 commit into from Oct 27, 2023

Conversation

kevinwcyu
Copy link
Contributor

  • Made the minimal amount of updates to dependencies to support Node 18
  • Tested with Node v18.17.1 locally with the following rm -rf node_modules && yarn && yarn lint && yarn test:ci && yarn build then tested it with a simple query

@kevinwcyu kevinwcyu requested a review from a team as a code owner September 14, 2023 19:40
@kevinwcyu kevinwcyu marked this pull request as draft September 14, 2023 19:59
@kevinwcyu kevinwcyu force-pushed the kevinwcyu/node-18 branch 3 times, most recently from 9686430 to 2ef229d Compare October 10, 2023 23:14
@kevinwcyu kevinwcyu marked this pull request as ready for review October 18, 2023 17:33
iwysiu
iwysiu approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally, and it works!

@kevinwcyu kevinwcyu merged commit 2933157 into main Oct 27, 2023
4 checks passed
@kevinwcyu kevinwcyu deleted the kevinwcyu/node-18 branch October 27, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwysiu iwysiu iwysiu approved these changes

@fridgepoet fridgepoet Awaiting requested review from fridgepoet fridgepoet is a code owner automatically assigned from grafana/aws-datasources

@idastambuk idastambuk Awaiting requested review from idastambuk idastambuk is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevinwcyu @iwysiu