Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy files from Go 1.19.2 #1

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Conversation

pstibrany
Copy link
Member

This PR copies latest version of regexp package from Go 1.19.2 into main.

@pstibrany pstibrany merged commit f072a00 into main Oct 5, 2022
@pstibrany pstibrany deleted the merge-upstream-changes-to-main branch October 5, 2022 09:34
@bboreham
Copy link
Collaborator

If I try this I get:

% go test ./...
# github.com/grafana/regexp
package github.com/grafana/regexp (test)
        exec_test.go:11:2: use of internal package internal/testenv not allowed
FAIL    github.com/grafana/regexp [setup failed]
ok      github.com/grafana/regexp/syntax        0.524s
FAIL

@pstibrany
Copy link
Member Author

pstibrany commented Nov 23, 2022

If I try this I get:

% go test ./...
# github.com/grafana/regexp
package github.com/grafana/regexp (test)
        exec_test.go:11:2: use of internal package internal/testenv not allowed
FAIL    github.com/grafana/regexp [setup failed]
ok      github.com/grafana/regexp/syntax        0.524s
FAIL

That's my bad, fixing in #6 (for speedup-golang-1.19.2 branch only, you fixed it on main)

I haven't realized that you have removed usage of internal on main when copying latest version of regexp package from Go 1.19.2. I mistakenly thought main branch is without changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants