copy files from master post go1.22.1 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This copies the state of regexp package at commit 2e1003e2f7e42efc5771812b9ee6ed264803796c which occurred sometime after go1.22.1 but before any other release. We remove the use of internal after copying. Additionally we bump the minimum supported version of go to 1.21 due to the features now used. Test Plan: go test ./...
|
|
bboreham
approved these changes
May 18, 2024
There was a problem hiding this comment.
Thanks for this, and sorry for the long wait to look at it.
Reading through, I noticed these changes:
- Most changes are formatting of comments.
- A few tests are extended.
slices.Equalandslices.Sortused where appropriate.- Named capture syntax extended.
A more complete list can be found at https://github.com/golang/go/commits/2e1003e2f7e42efc5771812b9ee6ed264803796c/src/regexp
The last change included is golang/go@51a96f8.
I don't expect any of thses changes to impact the optimisations (on the speedups branch).
| for i := range b.visited { | ||
| b.visited[i] = 0 | ||
| } | ||
| clear(b.visited) // set to 0 |
There was a problem hiding this comment.
reviewing note: clear was added in Go 1.21 so this change is OK for projects that target last two versions.
| if size < 1 { | ||
| size = 1 | ||
| } | ||
| size = max(1, size) |
There was a problem hiding this comment.
note max and min were added in Go 1.21
bboreham
added a commit
to grafana/mimir
that referenced
this pull request
May 30, 2024
This brings in grafana/regexp#11, so that long lists of alternates that escape FastRegexpMatcher will get sorted and hence execute faster. The bulk of this PR is grafana/regexp#10 which brings the library up-to-date with Go 1.22.1; mostly cosmetic but a couple of code improvements.
bboreham
added a commit
to grafana/mimir
that referenced
this pull request
May 30, 2024
This brings in grafana/regexp#11, so that long lists of alternates that escape FastRegexpMatcher will get sorted and hence execute faster. The bulk of this PR is grafana/regexp#10 which brings the library up-to-date with Go 1.22.1; mostly cosmetic but a couple of code improvements.
1 task
bboreham
added a commit
to grafana/mimir
that referenced
this pull request
May 30, 2024
This brings in grafana/regexp#11, so that long lists of alternates that escape FastRegexpMatcher will get sorted and hence execute faster. The bulk of this PR is grafana/regexp#10 which brings the library up-to-date with Go 1.22.1; mostly cosmetic but a couple of code improvements.
bboreham
added a commit
to grafana/mimir
that referenced
this pull request
May 30, 2024
This brings in grafana/regexp#11, so that long lists of alternates that escape FastRegexpMatcher will get sorted and hence execute faster. The bulk of this PR is grafana/regexp#10 which brings the library up-to-date with Go 1.22.1; mostly cosmetic but a couple of code improvements.
narqo
pushed a commit
to narqo/grafana-mimir
that referenced
this pull request
Jun 6, 2024
This brings in grafana/regexp#11, so that long lists of alternates that escape FastRegexpMatcher will get sorted and hence execute faster. The bulk of this PR is grafana/regexp#10 which brings the library up-to-date with Go 1.22.1; mostly cosmetic but a couple of code improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies the state of regexp package at commit golang/go@2e1003e which occurred sometime after go1.22.1 but before any other release. We remove the use of internal after copying.
Additionally we bump the minimum supported version of go to 1.21 due to the features now used.
Test Plan: go test ./...