Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unified way to validate river identifiers #18

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

erikbaranowski
Copy link
Contributor

add a configurable way to sanitize a string into a river identifier.

add a configurable way to sanitize a string into a river identifier.

Signed-off-by: erikbaranowski <39704712+erikbaranowski@users.noreply.github.com>
scanner/identifier.go Outdated Show resolved Hide resolved
Signed-off-by: erikbaranowski <39704712+erikbaranowski@users.noreply.github.com>
Signed-off-by: erikbaranowski <39704712+erikbaranowski@users.noreply.github.com>
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % feedback.

scanner/identifier.go Outdated Show resolved Hide resolved
scanner/identifier_test.go Outdated Show resolved Hide resolved
scanner/identifier_test.go Outdated Show resolved Hide resolved
add fuzz and benchmark testing

Signed-off-by: erikbaranowski <39704712+erikbaranowski@users.noreply.github.com>
Signed-off-by: erikbaranowski <39704712+erikbaranowski@users.noreply.github.com>
Signed-off-by: erikbaranowski <39704712+erikbaranowski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants