Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: improve function comments #102

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

pracucci
Copy link
Collaborator

I was reviewing #99 (post merge) and I've found the documentation of findDownscalesDoneMinTimeAgo() a bit poor. In this PR I'm proposing a longer description of the funciton.

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci requested a review from a team as a code owner December 14, 2023 08:29
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@pracucci pracucci merged commit 59f1ca3 into main Dec 14, 2023
6 checks passed
@pracucci pracucci deleted the chose-improve-function-comments branch December 14, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants