Support for delay between call to prepare-downscale and actual downscale. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elayBeforeShutdownAnnotationKey to indicate it's an annotation.
|
Closing this in favor of resource mirroring + delayed scaledown in controller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan to run new ingesters with delay between prepare-downscale and actual downscale. During this delay, ingesters will keep running, but will not receive any new data.
Timestamp of prepare-downscale call is recorded as Pod annotation.
After delay elapses (checked as max recorded timestamp in pod annotations), rollout operator's admission controller allows final downscale.
User can cancel the downscale during this delay, and scale up again. In that case rollout operator can be configured to call
DELETEon prepare-downscale endpoint.(draft, doing manual testing)