Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider missing pods as not ready #127

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Conversation

colega
Copy link
Contributor

@colega colega commented Jan 24, 2024

If all pods are missing, we can't say there are no "not ready pods".

Fixes: #126

Signed-off-by: Oleg Zaytsev mail@olegzaytsev.com

If all pods are missing, we can't say there are no "not ready pods".

Fixes: #126

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
@colega colega requested a review from pracucci January 24, 2024 16:21
@colega colega marked this pull request as ready for review January 24, 2024 16:21
@colega colega requested a review from a team as a code owner January 24, 2024 16:21
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @colega. I think the change is safe and fixes a real issue. I left a couple of nits I would be glad you could take a look at before merging.

pkg/controller/controller.go Outdated Show resolved Hide resolved
pkg/controller/controller.go Show resolved Hide resolved
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Copy link
Contributor

@pr00se pr00se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@colega colega merged commit cfbbe58 into main Jan 25, 2024
6 checks passed
@colega colega deleted the consider-missing-pods-as-not-ready branch January 25, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator assumes all pods are ready when there are no pods at all
3 participants