Makefile: Set dependencies for binary #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Makefile, set the dependencies for the rollout-operator binary so it gets re-built when Go files change. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
andyasp
approved these changes
Mar 29, 2023
Co-authored-by: Andy Asp <90626759+andyasp@users.noreply.github.com>
krajorama
approved these changes
Apr 11, 2023
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Makefile, set the dependencies for the rollout-operator binary so it gets re-built when Go files change.
I've copied and adapted the logic from the Mimir Makefile for finding Go source files. Please review whether this logic makes sence, since it's a bit hairy :)