Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update indirect docker dependency for CVE-2023-28840 #50

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Update indirect docker dependency for CVE-2023-28840 #50

merged 1 commit into from
Apr 20, 2023

Conversation

andyasp
Copy link
Collaborator

@andyasp andyasp commented Apr 20, 2023 •
edited

CVE-2023-28840 popped up again after merging #49
This is only relevant to the integration tests and appeasing scanners.

$ go mod why -m github.com/docker/docker
# github.com/docker/docker
github.com/grafana/rollout-operator/integration/k3t
github.com/k3d-io/k3d/v5/pkg/client
github.com/k3d-io/k3d/v5/pkg/runtimes/docker
github.com/docker/docker/api/types

I didn't include a changelog entry due to this and #49 says "including" to not list other indirect dependencies.

@andyasp andyasp added the chore label Apr 20, 2023
@andyasp andyasp requested a review from a team as a code owner April 20, 2023 16:41
56quarters
56quarters approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta make the scanners happy. LGTM, thanks!

@andyasp andyasp merged commit cd69d8c into main Apr 20, 2023
4 checks passed
@andyasp andyasp deleted the aasp/docker-cve branch April 20, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@56quarters 56quarters 56quarters approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andyasp @56quarters