Reinstate /ingester/ prefix #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
56quarters
approved these changes
Apr 24, 2023
|
I don't like having to enforce a given random prefix here. There's no such thing as an ingester in the scope of Discussed on slack with @MichelHollands, it seems that annotations are a better fit to store this data (port & path). |
|
Closing this and I'll add another PR with annotations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels in Kubernetes do not allow the
/character. Therefore the/ingester/prefix needs to be added.Found this while working on an integration test for the downscale webhook.