Drop specifying go patch version #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the patch version being specified for Go from both the Dockerfile and CI.
The aim of this is to only require intervention on Go minor version upgrades. Currently this effectively upgrades to go 1.20.5.
The CI workflow was changed according to node semver. The current specification
^1.20.4actually meant>=1.20.4 < 2.0.0. Given the dependencies of this project, minor version changes actually cause breakage like in #39.1.20means>=1.20.0 < 1.21.0, where thecheck-latest: trueensures we're on the latest patch version, effectively matching the Docker tag behavior.I also updated to
actions/setup-go@v4, which isn't really necessary for these changes, but I noticed there was a new version while doing this.