Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move label and annotation names to a central package #68

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

56quarters
Copy link
Contributor

They were previously located all over the codebase. This allows them to be used by any part of the rollout-operator from a single location.

They were previously located all over the codebase. This allows
them to be used by any part of the rollout-operator from a single
location.

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
@56quarters 56quarters marked this pull request as ready for review June 23, 2023 18:15
@56quarters 56quarters requested a review from a team as a code owner June 23, 2023 18:15
Copy link
Collaborator

@andyasp andyasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing annotations.go entirely threw me for a second until I realized you moved the functions to prep_downscale.go. LGTM

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@56quarters 56quarters merged commit 0770d65 into main Jun 27, 2023
5 checks passed
@56quarters 56quarters deleted the 56quarters/config-cleanup branch June 27, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants