Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #70

Merged
merged 6 commits into from
Aug 3, 2023
Merged

Update dependencies #70

merged 6 commits into from
Aug 3, 2023

Conversation

andyasp
Copy link
Collaborator

@andyasp andyasp commented Jul 13, 2023

It's been over a month since the last build, so this is part of preparing for another one.
Summary:

  • github.com/prometheus/client_golang from v1.15.1 to v1.16.0
  • github.com/sirupsen/logrus from v1.9.2 to v1.9.3
  • golang.org/x/sync from v0.2.0 to v0.3.0
  • k8s.io/api from v0.27.2 to v0.27.3
  • k8s.io/apimachinery from v0.27.2 to v0.27.3
  • k8s.io/client-go from v0.27.2 to v0.27.3

@andyasp andyasp added the chore label Jul 13, 2023
@andyasp andyasp requested a review from a team as a code owner July 13, 2023 14:15
@andyasp
Copy link
Collaborator Author

andyasp commented Jul 13, 2023

Seeing this failure in integration tests:

Failed Cluster Start: error during post-start cluster preparation: error overwriting contents of /etc/hosts: docker failed to attach to exec process in node 'k3d-k3d-test-1689258604854-server-0': http: invalid Host header

Not sure why currently.

@andyasp
Copy link
Collaborator Author

andyasp commented Jul 13, 2023

go 1.20.6 (released two days ago) included increased host header sanitization which caused a bug with docker. Dependencies seem to still be sorting this out, so waiting a bit is probably the best plan.

@andyasp andyasp marked this pull request as draft July 13, 2023 20:02
@andyasp
Copy link
Collaborator Author

andyasp commented Jul 19, 2023

The above issue is still ongoing. It's looking like docker will be releasing the fix in 24.0.5. An issue to reference is here.

@andyasp
Copy link
Collaborator Author

andyasp commented Jul 25, 2023

Manually updating the indirect dependencies docker/docker and docker/cli to v24.0.5 breaks k3d, so the fun train is still rolling.

@andyasp andyasp marked this pull request as ready for review August 3, 2023 15:11
@andyasp
Copy link
Collaborator Author

andyasp commented Aug 3, 2023

k3d released an update 10 hours ago so this is now unblocked.

@pracucci pracucci self-requested a review August 3, 2023 16:55
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch versions for K8S, other dependency changes looks safe, so LGTM

Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't believe integration tests passed on the first try, thanks!

@56quarters 56quarters merged commit c261138 into main Aug 3, 2023
6 checks passed
@56quarters 56quarters deleted the aasp/update-dependencies branch August 3, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants