Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go to 1.21 #77

Merged
merged 5 commits into from
Aug 11, 2023
Merged

Update Go to 1.21 #77

merged 5 commits into from
Aug 11, 2023

Conversation

andyasp
Copy link
Collaborator

@andyasp andyasp commented Aug 10, 2023

Updates the intermediate build container and CI to run on Go 1.21

@andyasp andyasp added the chore label Aug 10, 2023
@andyasp
Copy link
Collaborator Author

andyasp commented Aug 10, 2023

As a note tested go.mod with go 1.21 just to see if anything blew up and it was fine. I don't see a need to declare that strict minimum now though so only bumped that to go 1.20.

@andyasp andyasp marked this pull request as ready for review August 10, 2023 17:46
@andyasp andyasp requested a review from a team as a code owner August 10, 2023 17:46
charleskorn
charleskorn approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Andy

@andyasp andyasp merged commit 29dc139 into main Aug 11, 2023
6 checks passed
@andyasp andyasp deleted the aasp/go-1.21 branch August 11, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskorn charleskorn charleskorn approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andyasp @charleskorn