Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flaky TestExpiringCertificate #85

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

jhalterman
Copy link
Member

@jhalterman jhalterman commented Sep 20, 2023

This PR removes a flaky e2e test, TestExpiringCertificate, which has been failing for numerous PRs.

@jhalterman jhalterman changed the title Disable flaky TestExpriingCertificate Disable flaky TestExpiringCertificate Sep 20, 2023
@jhalterman jhalterman changed the title Disable flaky TestExpiringCertificate Remove flaky TestExpiringCertificate Sep 20, 2023
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☠️ 🔥

@jhalterman jhalterman marked this pull request as ready for review September 20, 2023 20:39
@jhalterman jhalterman requested a review from a team as a code owner September 20, 2023 20:39
@56quarters 56quarters merged commit cabaac5 into grafana:main Sep 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants