Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile in bookworm and update alpine to 3.19 #97

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

andyasp
Copy link
Collaborator

@andyasp andyasp commented Dec 8, 2023

@andyasp andyasp added the chore label Dec 8, 2023
@andyasp andyasp requested a review from a team as a code owner December 8, 2023 19:12
@andyasp andyasp marked this pull request as draft December 8, 2023 19:13
@andyasp
Copy link
Collaborator Author

andyasp commented Dec 8, 2023

Will have to wait for the golang image to be updated.

@andyasp
Copy link
Collaborator Author

andyasp commented Dec 9, 2023

Reran the tests since golang uploaded the new images, but now there's a build failure with boringcrypto:

#14 [build 5/5] RUN GOOS=linux GOARCH=amd64 make rollout-operator-boringcrypto
#14 0.183 GOEXPERIMENT=boringcrypto GOOS=linux GOARCH=amd64 CGO_ENABLED=1 go build -tags netgo ./cmd/rollout-operator
#14 50.25 # github.com/grafana/rollout-operator/cmd/rollout-operator
#14 50.25 /usr/local/go/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
#14 50.25 /usr/lib/gcc/x86_64-alpine-linux-musl/13.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: /tmp/go-link-4052097540/000023.o: in function `BIO_new_file':
#14 50.25 (.text+0xcb1dc): undefined reference to `fopen64'
#14 50.25 /usr/lib/gcc/x86_64-alpine-linux-musl/13.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: /tmp/go-link-4052097540/000023.o: in function `BIO_rw_filename':
#14 50.25 (.text+0xcb60d): undefined reference to `fopen64'
#14 50.25 collect2: error: ld returned 1 exit status

@andyasp
Copy link
Collaborator Author

andyasp commented Dec 13, 2023

The build issue has already been reported upstream. There's no rush in going to 3.19 for us so I'll keep this PR in draft for the time being.

@andyasp
Copy link
Collaborator Author

andyasp commented Dec 18, 2023

In the go issue fixing this was declined. Seems that we'll have to go back to compiling in a glibc environment in order to move forward. As a note we've been compiling in alpine since boringcrypto was introduced here in #71.

@andyasp andyasp marked this pull request as ready for review December 18, 2023 22:02
@andyasp andyasp changed the title Update alpine to 3.19 Compile in bookworm and update alpine to 3.19 Dec 18, 2023
@andyasp andyasp marked this pull request as draft December 18, 2023 22:03
@andyasp
Copy link
Collaborator Author

andyasp commented Dec 18, 2023

Double checked for BoringCrypto in the runtime boringcrypto container (modified to include go for the check):

$ go tool nm /bin/rollout-operator | grep Boring
  16ea60 T crypto/internal/boring/sig.BoringCrypto.abi0
   666a0 t kBoringSSLRSASqrtTwo
   667a0 t kBoringSSLRSASqrtTwoLen
$ go tool nm /bin/rollout-operator | grep StandardCrypto

@andyasp andyasp marked this pull request as ready for review December 18, 2023 22:17
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also tried building the image locally and can confirm this correctly builds a boringcrypto image. Thanks for taking care of it!

@andyasp andyasp merged commit fe4e0d7 into main Dec 19, 2023
6 checks passed
@andyasp andyasp deleted the aasp/update-alpine branch December 19, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants