Implement query signature verification (#11) #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement query signature verification add support for sha1 & sha512 add tests * use query sign in redirect * implement review feedback - Return error if signature is unsupported - wrap errors Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>
|
An alternative for #15, rebased the query signature commit on top of master. untested (I have no idea how to test it). |
|
You are right @orgads , this commit is missing from the main branch. I'm bringing this to the attention of another maintainer to get this sorted |
|
You're welcome. Do you have a schedule for the next release with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for sha1 & sha512
add tests
use query sign in redirect
implement review feedback
Co-authored-by: Ieva ieva.vasiljeva@grafana.com