Fix logout response validation #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderzobnin
commented
Feb 3, 2023
Jguer
reviewed
Feb 3, 2023
| retErr.PrivateErr = err | ||
| return retErr | ||
| } | ||
|
|
||
| if err := sp.validateSignature(doc.Root()); err != nil { | ||
| retErr.PrivateErr = err | ||
| return retErr | ||
| if err != errSignatureElementNotPresent || !hasValidSignature { |
There was a problem hiding this comment.
👍 if I understand it correctly, we're checking here if either the assertions are signed or the document itself is signed.
One of which most be true
There was a problem hiding this comment.
Yes, we only want to fire error if no signature was found at all or if it's wrong.
Jguer
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue described in crewjam#489
It contains 2 parts:
validateSignature()function is used widely in SP implementation.