Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filters: When changing filter dimension, the value should be validated or cleared #694

Closed
dprokop opened this issue Apr 15, 2024 · 1 comment · Fixed by #714
Closed

Filters: When changing filter dimension, the value should be validated or cleared #694

dprokop opened this issue Apr 15, 2024 · 1 comment · Fixed by #714
Assignees
@ashharrison90
Labels
released type/bug Something isn't working

Comments

@dprokop
Copy link
Member

dprokop commented Apr 15, 2024

Currently, when changing the filter dimension the value of that filter is kept intacted. This may produce wrong query results on refresh.

To reproduce:

  1. Apply a filter, e.g. foo = bar
  2. Change the filter dimension from foo to baz
  3. Filter value still shows bar, which doesn't make any sense at this point
  4. On refresh, queries are sent with filter baz = bar (which is wrong and may not even be of the same type)
@dprokop dprokop added the type/bug Something isn't working label Apr 15, 2024
@ashharrison90 ashharrison90 self-assigned this May 2, 2024
@ashharrison90 ashharrison90 mentioned this issue May 2, 2024
Merged
@grafanabot
Copy link
Contributor

🚀 Issue was released in v4.17.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashharrison90 ashharrison90

Labels
released type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AdHocFilters: clear filter value when key is changed grafana/scenes
3 participants
@dprokop @ashharrison90 @grafanabot