AdHocFilters: clear filter value when key is changed #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashharrison90
added
type/bug
dprokop
reviewed
May 7, 2024
There was a problem hiding this comment.
I found one thing that I think is worth addressing in this PR:
- Create a complete filter (label & value)
- Change filter dimension (observe, that the partial filter is synced to the URL)
- Refresh the page (observe that the filter value select is open).
I think we should treat the dimension change as new filter config transaction, meaning that the filter should not be commited to the URL until it's complete (dimension + value configured).
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #694
Fixes https://github.com/grafana/hyperion-planning/issues/20
📦 Published PR as canary version:
4.17.2--canary.714.9000579577.0✨ Test out this PR locally via:
npm install @grafana/scenes@4.17.2--canary.714.9000579577.0 # or yarn add @grafana/scenes@4.17.2--canary.714.9000579577.0