VizPanel: Allow queries to be cancelled #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprokop
reviewed
May 31, 2023
|
Would appreciate a demo scene in scene-app for testing this behavior :) |
I think the lazy loading demo should work for testing (the queries take at least 5 seconds) |
dprokop
requested changes
Jun 1, 2023
dprokop
added
minor
dprokop
reviewed
Jun 1, 2023
|
Not sure what the best approach is for checking if a SQR is shared between multiple panels |
torkelo
reviewed
Jun 7, 2023
kaydelaney
commented
Jun 8, 2023
torkelo
reviewed
Jun 14, 2023
torkelo
reviewed
Jun 14, 2023
dprokop
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Looks good now @kaydelaney! I see only one comment left from @torkelo and I think we should be good to land this :)
torkelo
reviewed
Jun 17, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure this is the right approach (specifically with how I'm getting the closest SceneQueryRunner), but it seems to work.
Part of #207
Will tackle query variable cancellation in another PR
📦 Published PR as canary version:
0.17.0--canary.220.5309552119.0✨ Test out this PR locally via:
npm install @grafana/scenes@0.17.0--canary.220.5309552119.0 # or yarn add @grafana/scenes@0.17.0--canary.220.5309552119.0