LiveNow: Fixes activation/deactivation issue and logic error with getTimeRange #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
reviewed
Mar 13, 2024
| } | ||
| }, LiveNowTimer.REFRESH_RATE); | ||
| } | ||
| window.clearInterval(this.timerId); |
There was a problem hiding this comment.
why window.clearInterval here, does not clearInterval work the same?
There was a problem hiding this comment.
Just a typing thing. clearInterval on its own has NodeJS types
whereas window.clearInterval doesn't:
torkelo
reviewed
Mar 13, 2024
| window.clearInterval(this.timerId); | ||
| this.timerId = undefined; | ||
| this.enabled = true; | ||
| this.timerId = window.setInterval(() => { |
There was a problem hiding this comment.
same ehre, why window.setInterval
torkelo
approved these changes
Mar 13, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.