AdHocFilter: Correctly show the label for a matching default key #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashharrison90
added
type/bug
3 tasks
torkelo
approved these changes
Mar 15, 2024
dprokop
approved these changes
Mar 15, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses grafana/grafana#83157 (comment)
in
AdHocFilterRendererthe selected value for that select is constructed from the filter key here. this uses thetoOptionmethod which just takes the value and applies it as both the label and valuethis changes the behaviour when
defaultKeysare present to find the matching option from the list ofdefaultKeys, then usestoSelectableValueto convert it. that way both the label and internal value are preserved correctly